Repository navigation
Eliminate redundant apply for fileCollection helper - #2342
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single-line refactor preserves convention initialization and the returned collection, with no unresolved findings.
No open issues 🎉
What changed in this PR
This PR simplifies the internal fileCollection helper by removing a redundant apply block while preserving its behavior and return type.
Changes:
- Returns the result of
convention(path())directly. - Retains the unstable API warning suppression.
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/GradleCompat.kt | Simplifies file collection initialization without changing behavior. |
Review effort: Balanced
Goooler
enabled auto-merge (squash)
October 25, 2026 07:37
Goooler
force-pushed
the
g/20261025/convention-helper
branch
from
October 25, 2026 07:50
bc841f9 to
5eb9a40
Compare
Goooler
disabled auto-merge
October 25, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.