Repository navigation
Conversation
Nobody consumes the timestamps of the shadowed sources JAR, so always use CONSTANT_TIME_FOR_ZIP_ENTRIES. This lets it share the parent directory entry writing with ShadowCopyAction.
Goooler
added this pull request to stack #2347
October 25, 2026 12:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nobody consumes the timestamps of the shadowed sources JAR, so its entries now always use
CONSTANT_TIME_FOR_ZIP_ENTRIES, regardless ofisPreserveFileTimestamps. Since Gradle 9, archive tasks default topreserveFileTimestamps = false, so this only changes the output when it is explicitly enabled.This lets the shadowed sources JAR share the parent directory entry writing with
ShadowCopyAction. That logic moves fromShadowCopyAction.addDirstoZipOutputStream.writeParentDirectoryEntries. As a result, directory entries in the sources JAR are now ordered deepest first (e.g.z/sub/,z/), matching the shadowed JAR. Entry order doesn't affect consumers, since ZIP readers look entries up through the central directory.Follow up #2265.