Repository navigation
Tablet: Open Start chat in the detail pane - #463
Merged
Merged
Conversation
RankoR
self-requested a review
October 28, 2026 16:36
RankoR
suggested changes
Oct 28, 2026
| LaunchedEffect(Unit) { | ||
| // Focusing before the first layout crashes Compose's lookahead measure when the | ||
| // window turns two-pane and the list-detail scaffold is built around this screen | ||
| withFrameNanos {} |
Contributor
Author
There was a problem hiding this comment.
I don't disagree.
https://issuetracker.google.com/issues/567222742
On rotation, it tried to autofocus on a non-existing (now) element [rotation rebuilds everything?]
Here's an actual fix, I don't think it deserves a separate PR, but it's up to you.
8436281
talanov
force-pushed
the
fix/tablet/new-chat-detail
branch
from
October 28, 2026 21:37
491039e to
061cb86
Compare
…arge screens instead of over both panes (fixes GrapheneOS#380)
…otates between one and two panes
… between one and two panes
talanov
force-pushed
the
fix/tablet/new-chat-detail
branch
from
October 28, 2026 22:01
061cb86 to
696393f
Compare
RankoR
approved these changes
Oct 28, 2026
RankoR
left a comment
RankoR
left a comment
Member
There was a problem hiding this comment.
LGTM for v19, also needs testing.
|
Tested PR #463 on an Android 16 (API 36) tablet emulator. Verified:
No issues observed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #380
