Repository navigation
currentColor in a border raises warnings and draws black, and a border with no colour is not drawn in the text colour #540
Description
Part of #520 (step 19).
Measured on gravitypdf at d660a410, PHP 8.5.4.
Rule on <p> |
Browser | mPDF |
|---|---|---|
color:#0f0; border:1px solid currentColor |
green border | black border, and two "Uninitialized string offset 0" warnings from _setBorderLine() (src/Mpdf.php:17933, :17935) |
color:#0f0; border:1px solid |
green border: the initial value of border-color is currentColor |
black border |
currentColor is not converted, so the border's colour comes out empty, and _setBorderLine() reads $b['c'][0] from an empty string.
Fix. Resolve currentColor to the element's computed color once its properties are merged, for each border side and every other colour property that accepts it. A border with no colour takes currentColor.
Tests. Both rows, with the color inherited as well as set, and no warning.
Also from #552: other colours that convert to nothing. The same failure causes these. Measured on gravitypdf at d660a410:
| Rule | Browser | mPDF |
|---|---|---|
div{border:4mm solid transparent; border-bottom-color:#c00} |
only the bottom border shows | top, left and right are black, with "Trying to access array offset on false" from _setBorderLine() (src/Mpdf.php:17933, :17935) |
div{border:3mm hidden #36c} |
no border | a black hairline, with "Uninitialized string offset 0" from the same lines |
p{color:transparent} |
invisible text | black text: ColorConverter returns false and setCSS() keeps the previous colour |
div{color:#c00; box-shadow:2mm 2mm}, p{color:#c00; text-shadow:1mm 1mm} |
shadows in #cc0000 |
shadows in #888888 (src/Css/ShadowParser.php:143, :247-248) |
Fix them here. A transparent side or a hidden style draws nothing, transparent text is invisible, and a shadow with no colour takes currentColor.
Tests (also). Each row, with no warning.
Activity