Repository navigation
Under cssMode legacy, a descendant rule on a table part with an omitted end tag reaches the rows after it #630
Description
When a table row's </tr> is left out, a descendant rule on that row also applies to every row after it.
<style>tr:nth-child(2) td { color: #f00 }</style>
<table>
<tr><td>A1</td><td>A2</td>
<tr><td>B1</td><td>B2</td>
<tr><td>C1</td><td>C2</td>
</table>| Cells | Browser | mPDF (gravitypdf at de2a2d4) |
|---|---|---|
| A1, A2 | black | black |
| B1, B2 | red | red |
| C1, C2 | black | red |
With every </tr> written, C1 and C2 are black, as expected.
Likely cause
Not yet confirmed in the code. The index is correct: the stack of open elements (#533) closes the second row when the third <tr> starts, and #629 reads tr:nth-child from it. The fault looks to be in the legacy table cascade: the rules lifted at a row into CssManager::$tablecascadeCSS seem to be dropped only when that row's </tr> is read. A <tr> that implicitly ends the previous row would then leave them in place, so the third row's cells still match tr:nth-child(2) td.
Found while working on #629. Under the standard cascade from #535 the matcher decides this from the element stack, so the fix only has to cover the legacy cascade.
Part of #520.
Activity
jakejackson1 commentedon Sep 30, 2026
Update at e685435, now that #631 has added
cssMode:cssModestandard(the default) the matcher decides from the element stack, and C1 and C2 are black. Under'cssMode' => \Mpdf\CssMode::LEGACYthey are still red.</th>around a block in thethead, and thetheadrules reach the body cells, again under legacy only:"Body" is drawn red under legacy. Written with
</th>, it is black. Both cases look like the legacy table cascade keeping a level's rules when an end tag is implied, not read.[-]A descendant rule on a row with no end tag applies to the rows after it[/-][+]Under cssMode legacy, a descendant rule on a table part with an omitted end tag reaches the rows after it[/+]Close a table cell, row or row group whose end tag is left out where …