Skip to content

Expose hiscore and adventurer log webpages - #1339

Merged
GregHib merged 4 commits into
mainfrom
web-service-apis
Sep 24, 2026
Merged

GregHib merged 4 commits into
mainfrom
web-service-apis

Conversation

@GregHib

@GregHib GregHib commented Sep 24, 2026

Copy link
Copy Markdown
Owner
  • Add hiscores page
  • Add adventurer log page
  • Add web server results caching
  • Add boss icons

@github-actions

Copy link
Copy Markdown
Contributor

Qodana for JVM

4 new problems were found

Inspection name Severity Problems
Multi-dollar interpolation can be used in string literals ◽️ Notice 3
Variable declaration could be moved into 'when' ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov

codecov Bot commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.86765% with 169 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.20%. Comparing base (011bafc) to head (14d4a48).

Files with missing lines Patch % Lines
...world/gregs/voidps/web/hiscores/HiscoresService.kt 0.00% 94 Missing ⚠️
...world/gregs/voidps/web/exchange/ExchangeService.kt 0.00% 52 Missing ⚠️
...in/kotlin/world/gregs/voidps/web/dev/DevService.kt 0.00% 12 Missing ⚠️
...tlin/world/gregs/voidps/storage/DatabaseStorage.kt 95.06% 0 Missing and 4 partials ⚠️
.../kotlin/world/gregs/voidps/web/PeriodicSnapshot.kt 86.95% 2 Missing and 1 partial ⚠️
...world/gregs/voidps/web/api/route/HiscoresRoutes.kt 0.00% 2 Missing ⚠️
...ain/kotlin/world/gregs/voidps/web/api/route/Api.kt 80.00% 1 Missing ⚠️
...world/gregs/voidps/web/api/route/ExchangeRoutes.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...n/world/gregs/voidps/web/api/route/WorldsRoutes.kt 91.30% <100.00%> (+0.19%) ⬆️
...ain/kotlin/world/gregs/voidps/web/api/route/Api.kt 42.85% <80.00%> (+8.64%) ⬆️
...world/gregs/voidps/web/api/route/ExchangeRoutes.kt 0.00% <0.00%> (ø)
...world/gregs/voidps/web/api/route/HiscoresRoutes.kt 0.00% <0.00%> (ø)
.../kotlin/world/gregs/voidps/web/PeriodicSnapshot.kt 86.95% <86.95%> (ø)
...tlin/world/gregs/voidps/storage/DatabaseStorage.kt 81.57% <95.06%> (+3.79%) ⬆️
...in/kotlin/world/gregs/voidps/web/dev/DevService.kt 0.00% <0.00%> (ø)
...world/gregs/voidps/web/exchange/ExchangeService.kt 0.00% <0.00%> (ø)
...world/gregs/voidps/web/hiscores/HiscoresService.kt 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@@             Coverage Diff              @@
##               main    #1339      +/-   ##
============================================
+ Coverage     44.18%   44.20%   +0.02%     
- Complexity    11425    11457      +32     
============================================
  Files          2189     2190       +1     
  Lines        101994   102084      +90     
  Branches      16372    16382      +10     
============================================
+ Hits          45065    45130      +65     
- Misses        50543    50553      +10     
- Partials       6386     6401      +15     
Components Coverage Δ
Content 44.99% <ø> (-0.01%) ⬇️
Engine 46.01% <ø> (+0.03%) ⬆️
Network 72.01% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib
GregHib merged commit f401b83 into main Sep 24, 2026
5 checks passed
@GregHib
GregHib deleted the web-service-apis branch September 24, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant