OSC 52 protocol implementation - #2333
Open
bitifet wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements OSC 52 (allow modern clipboad integration)
Fixes #2222
DISCLAIMER
I'm an experienced developer. But not specialized in python nor terminals or even the OSC 52 protocol.
Just a (grateful) long-term guake user that needs a OSC 52 compilant terminal and found no alternative that fit my needs like Guake does.
Then thought this is a perfect task for an AI agent and asked @copilot to implement it.
It did it at first attempt.
I reviewed the diff from master branch. It looks fine to me. I saw nothing harm.
Followed repository instructions to compile and install and worked at first attempt.
I'm already using it now.
Tried to follow your instructions for the PR, but got issues and sadly I have no time to go further.
Anyway, and even what I did is (nowadays) easy, cheap and has no merit, I think it is still worth to contribute since it fixes a log term issue (not as easy to solve back then) and I hope guake mantainers woudl be so kind to take an eye on it if they can and fix whatever is missing from their guake's knowledge that is way greater than mine.
Otherwise I appologize for the inconvenience and feel free to reject this PR if you want.
Here the first failing of the required steps to make a pull request:
Thanks for your attention.