Skip to content

OSC 52 protocol implementation - #2333

Open
bitifet wants to merge 2 commits into
Guake:masterfrom
bitifet:copilot/implement-osc-52-protocol
Open

OSC 52 protocol implementation#2333
bitifet wants to merge 2 commits into
Guake:masterfrom
bitifet:copilot/implement-osc-52-protocol

Conversation

@bitifet

@bitifet bitifet commented Jul 18, 2026

Copy link
Copy Markdown

Implements OSC 52 (allow modern clipboad integration)
Fixes #2222

DISCLAIMER

I'm an experienced developer. But not specialized in python nor terminals or even the OSC 52 protocol.

Just a (grateful) long-term guake user that needs a OSC 52 compilant terminal and found no alternative that fit my needs like Guake does.

Then thought this is a perfect task for an AI agent and asked @copilot to implement it.

It did it at first attempt.

I reviewed the diff from master branch. It looks fine to me. I saw nothing harm.

Followed repository instructions to compile and install and worked at first attempt.

I'm already using it now.

Tried to follow your instructions for the PR, but got issues and sadly I have no time to go further.

Anyway, and even what I did is (nowadays) easy, cheap and has no merit, I think it is still worth to contribute since it fixes a log term issue (not as easy to solve back then) and I hope guake mantainers woudl be so kind to take an eye on it if they can and fix whatever is missing from their guake's knowledge that is way greater than mine.

Otherwise I appologize for the inconvenience and feel free to reject this PR if you want.

Here the first failing of the required steps to make a pull request:

  $ make style check reno-lint test
PIPENV_IGNORE_VIRTUALENVS=1 pipenv run pre-commit run --all-files
Creating a virtualenv for this project...
Pipfile: /home/joanmi/Nextcloud/prj/ui/guake/wt/pr-1/Pipfile
Using /usr/bin/python3 (3.12.3) to create virtualenv...
⠴ Creating virtual environment...created virtual environment CPython3.12.3.final.0-64 in 292ms
  creator CPython3Posix(dest=/home/joanmi/.local/share/virtualenvs/pr-1-jHHdXjoL, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(download=False, pip=bundle, via=copy, app_data_dir=/home/joanmi/.local/share/virtualenv)
    added seed packages: pip==24.0
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator

✔ Successfully created virtual environment!
Virtualenv location: /home/joanmi/.local/share/virtualenvs/pr-1-jHHdXjoL
Error: the command pre-commit could not be found within PATH or Pipfile's [scripts].
make: *** [Makefile:183: style] Error 1

Thanks for your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add support for OSC52 escape sequence

2 participants