Repository navigation
Add usize and isize pointer-width integer types - #4
Merged
Merged
Conversation
usize and isize take the size and alignment of ptr: 8 and 8 under lp64, 4 and 4 under ilp32. Document them in the README and add tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by gulliby
Before
The struct description language accepted
ptrfor pointer-sized fields, but there was no integer type that follows the platform pointer width, so lengths and offsets such assize_tor Rust'susizehad to be written asptror as a fixed-width integer.After
usizeandisizeare accepted whereverptris, including array elements and nested structs. Both have exactly the size and alignment ofptr: 8 and 8 underlp64, 4 and 4 underilp32. Other names such assize_tare still unknown types. For this struct:structpad layout --abi ilp32 ffi.spprints:How
src/structpad/types.py: two rows added toPRIMITIVE_TYPESright afterptr, with the same numbers asptr. The parser, layout, suggestions and renderers already read this table, so nothing else changes.tests/test_pointer_ints.py: five new tests (primitive sizes, layout under both ABIs,suggestandcheck, JSON output and the unknownsize_t). The existing 145 tests are untouched; the suite now has 150.README.md: a short paragraph and an example in the Input language section.