Repository navigation
Add count --largest K - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by gulliby
Before:
youngkit count Ncould only limit the largest part (--max-part K, at most K) or require distinct parts.After:
youngkit count N --largest Kcounts the partitions of N whose largest part is exactly K. The output has one more line,largest, that shows K.--largestand--max-partexclude each other and exit 2 with a message. The usage line and the README describe the new option. 285 top-level Go tests pass (280 before);go vetandgofmt -lreport nothing.How:
internal/count/largest.goholds the count, andinternal/cli/cmd_count.goreads the option. One new test file,internal/cli/count_largest_test.go, holds the cases. Four existing test lines change because they pin the usage text.