chore: 0 code smells, 0% duplication, 93.6% coverage - #89

Merged

HandyS11 merged 34 commits into

developfrom

chore/sonar-zero-smells-zero-dup-90-coverage

Sep 8, 2026

Commits on Sep 8, 2026

docs: spec for the SonarQube quality-target work

HandyS11
and
claude
committed
4464f33
docs: implementation plan for the SonarQube quality targets

HandyS11
and
claude
committed
2cad36f
refactor: group MarkerReply collaborators into a services record

HandyS11
and
claude
committed
cd7e7d7
refactor: take a MapRenderRequest instead of nine parameters

HandyS11
and
claude
committed
8d894e9
refactor: group the generator's dataset parameters into a record

HandyS11
and
claude
committed
f048be8
fix: keep MapRenderer.Render public per brief; make MapRenderRequest public

HandyS11
and
claude
committed
9c31fc3
test: pin ClanSnapshotDiffer emission order before refactor

HandyS11
and
claude
committed
33b8983
refactor: split ClanSnapshotDiffer.Diff into identity, membership and role steps

HandyS11
and
claude
committed
86bb24e
refactor: call AddInviteChanges and AddAttributeChanges directly from Diff

HandyS11
and
claude
committed
5feead0
test: cover WorkspaceReconciler branches before refactor

HandyS11
and
claude
committed
b96552a
refactor: split WorkspaceReconciler's two complex methods into named steps

HandyS11
and
claude
committed
199aad5
refactor: split DatasetValidator.ValidateSmelters into one method per rule

HandyS11
and
claude
committed
c6042ad
docs: correct the plan's smell-verification claim

HandyS11
and
claude
committed
25f22c3
feat: add EventLoopHostedService base for event-bus consumers

HandyS11
and
claude
committed
f36ae72
refactor: move six hosted services onto EventLoopHostedService

HandyS11
and
claude
committed
dbf0bda
fix: fail fast on an unyielded event loop and pin the stop-time join

HandyS11
and
claude
committed
8f7d001
test: pin pairing-coordinator behaviour before the generic collapse

HandyS11
and
claude
committed
4c75cc1
refactor: collapse the device pairing coordinators onto a generic base

HandyS11
and
claude
committed
5f90ee4
refactor: share the Discord device-poster body across switch, monitor and vending

HandyS11
and
claude
committed
cd7d690
refactor: share IDeviceChannelLocator so the pairing subclasses stop forwarding

HandyS11
and
claude
committed
4f05d98
refactor: share the paired-device store between switches and monitors

HandyS11
and
claude
committed
07b61a0
refactor: share the clan render shell between the #claninfo renderers

HandyS11
and
claude
committed
d17252a
refactor: use DurationFormat.Compact in the storage-monitor renderer

HandyS11
and
claude
committed
142aa12
refactor: extract the repeated relay guard

HandyS11
and
claude
committed
d7c0d1c
refactor: extract the repeated guard bodies in the vending and alarm modules

HandyS11
and
claude
committed
c4e16c1
chore: narrow sonar scope to code with testable seams

HandyS11
and
claude
committed
3fef048
test: cover ConnectionSupervisor's reconnect, teardown and error paths

HandyS11
and
claude
committed
4eb8e20
test: make the rig-guard and backoff-cap tests actually fence their behaviour

HandyS11
and
claude
committed
ad1b2a0
test: cover the vending store, track service, hosted service and commands

HandyS11
and
claude
committed
498423d
test: cover the events, map, chat, workspace, pairing and connection hosted services

HandyS11
and
claude
committed
b3f9df3
style: apply dotnet format

HandyS11
and
claude
committed
bbaa466
fix: make PairedDeviceEntity's non-entity status EF-enforced

HandyS11
and
claude
committed
1aa17dc
fix: honour the host's stop deadline when joining event loops

HandyS11
and
claude
committed
264636e
style: apply dotnet format

HandyS11
and
claude
committed
6ca216f

Navigation Menu

chore: 0 code smells, 0% duplication, 93.6% coverage - #89

chore: 0 code smells, 0% duplication, 93.6% coverage#89
HandyS11 merged 34 commits into
developfrom
chore/sonar-zero-smells-zero-dup-90-coverage

Commits on Sep 8, 2026

docs: spec for the SonarQube quality-target work

docs: implementation plan for the SonarQube quality targets

refactor: group MarkerReply collaborators into a services record

refactor: take a MapRenderRequest instead of nine parameters

refactor: group the generator's dataset parameters into a record

fix: keep MapRenderer.Render public per brief; make MapRenderRequest public

test: pin ClanSnapshotDiffer emission order before refactor

refactor: split ClanSnapshotDiffer.Diff into identity, membership and role steps

refactor: call AddInviteChanges and AddAttributeChanges directly from Diff

test: cover WorkspaceReconciler branches before refactor

refactor: split WorkspaceReconciler's two complex methods into named steps

refactor: split DatasetValidator.ValidateSmelters into one method per rule

docs: correct the plan's smell-verification claim

feat: add EventLoopHostedService base for event-bus consumers

refactor: move six hosted services onto EventLoopHostedService

fix: fail fast on an unyielded event loop and pin the stop-time join

test: pin pairing-coordinator behaviour before the generic collapse

refactor: collapse the device pairing coordinators onto a generic base

refactor: share the Discord device-poster body across switch, monitor and vending

refactor: share IDeviceChannelLocator so the pairing subclasses stop forwarding

refactor: share the paired-device store between switches and monitors

refactor: share the clan render shell between the #claninfo renderers

refactor: use DurationFormat.Compact in the storage-monitor renderer

refactor: extract the repeated relay guard

refactor: extract the repeated guard bodies in the vending and alarm modules

chore: narrow sonar scope to code with testable seams

test: cover ConnectionSupervisor's reconnect, teardown and error paths

test: make the rig-guard and backoff-cap tests actually fence their behaviour

test: cover the vending store, track service, hosted service and commands

test: cover the events, map, chat, workspace, pairing and connection hosted services

style: apply dotnet format

fix: make PairedDeviceEntity's non-entity status EF-enforced

fix: honour the host's stop deadline when joining event loops

style: apply dotnet format