Add AI review workflows, aimed at the stale-contradiction class - #667
Merged
Conversation
The 2026-09-05 DLC post-mortem found the review gap across repos is CI coverage rather than lens quality. This repo had companion-check, deploy, preview and validate workflows but no claude or gemini caller. It is also where the measurement pointed hardest: doc-to-doc stale contradiction was the largest uncovered multi-author defect class in the preceding window — 12 findings across 6 PRs — and nothing automated was looking for it here. Adds the standard thin callers of the reusables in HarperFast/ai-review-prompts at af81872e (main, 2026-09-01), plus validate-caller-workflows (fail-closed: no shadow jobs, SHA-pinned refs). Make its `validate` job a required status check on main. review-layers is `universal`; the harper/* layers describe core's internals and do not apply to prose. repo-specific-checks carries what the shared layers cannot know, led by the contradiction class: when a page changes a documented default, option, flag, endpoint or version, the sibling pages asserting the old value are now wrong. Plus versioned-docs snapshots, historic-redirects.ts, and the fact that `npm run lint` is a no-op stub (`echo 0`) so a green lint here is evidence of nothing. Both reviewers stay OPT-IN via label; CLAUDE_ALWAYS_ON / GEMINI_ALWAYS_ON are repo variables and are deliberately not set here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
dawsontoth
approved these changes
Sep 8, 2026
Ethan-Arrowood
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2026-09-05 DLC post-mortem measured where escaped defects are actually caught. The finding was that the gap is not lens quality but CI review coverage across repos — most Harper repos outside
harper/harper-prorun no automated review at all, so their defects are caught by humans and agents after the fact, or not at all.What this adds
Standard thin callers of the reusables in
HarperFast/ai-review-prompts, pinned toaf81872e(main, 2026-09-01) — the same ref harper and harper-pro are on.review-layers:universal— theharper/*layers describe core internals and do not apply to prose.repo-specific-checksnames what the shared layers cannot know: doc-to-doc stale contradiction (the largest uncovered multi-author defect class in the preceding window — 12 findings across 6 PRs), versioned-docs snapshots,historic-redirects.ts, and the fact thatnpm run lintis a no-op stub (echo 0) so a green lint here is evidence of nothing.validate-caller-workflows— the fail-closed check that these callers carry no shadow job (a non-uses:job alongside the reusable call would run with the caller's permissions without the auth gate) and that both refs pin to a 40-char SHA.For the human reviewer
CLAUDE_ALWAYS_ON/GEMINI_ALWAYS_ONare repo variables and I deliberately did not set them: turning them on spends money on every future PR, which is your call, not mine. Until then these fire only on theclaude-review/gemini-reviewlabel. Merging this PR changes nothing on its own — the variable is what makes it live.validatea required status check onmainonce merged; it is written to run unconditionally so it can be required without going permanently pending.workflow_callblock), and the caller shape is copied from harper's maintained callers rather than written fresh.HARPERFAST_AI_CLIENT_ID,HARPERFAST_AI_APP_PRIVATE_KEY, plusANTHROPIC_API_KEY/GEMINI_API_KEY). They are org-level, but I have no way to confirm this repo is in their selected-repository list — worth a check before flipping the variable.🤖 Generated with Claude Code