Remove Table.oldestRetainedAuditTime() docs: the accessor is withdrawn before release - #669
Open
dawsontoth wants to merge 1 commit into
Open
Remove Table.oldestRetainedAuditTime() docs: the accessor is withdrawn before release#669dawsontoth wants to merge 1 commit into
dawsontoth wants to merge 1 commit into
Conversation
… catch-up horizon (#660)" The accessor this documented is being removed from harper#2458 before it ships. Per kriszyp's review there (Dawson's decision, 2026-09-10): it had no caller except harper#2448, a public single-number floor binds a contract a per-origin resume vector could not honor, and it created a second resume-validity path where replication already checks inside the operation. The floor stays as internal infrastructure; Table.subscribe consumes it inside the resume in #2448, and that is where consumer-facing docs belong. This reverts commit 0d151a2.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the documentation for the oldestRetainedAuditTime(): number method from reference/resources/resource-api.md and simplifies the description of the startTime property. There are no review comments, and I have no feedback to provide.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-669 This preview will update automatically when you push new commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure revert of #660's merge commit (
0d151a2c), which documentedTable.oldestRetainedAuditTime()under av5.3.0badge. That method is being removed from HarperFast/harper#2458 before it ships, so this page must not describe it.Why it is withdrawn — per kriszyp's review of harper#2458 (Dawson's decision, 2026-09-10): the accessor had no caller except harper#2448; a public single-number floor binds a contract that a per-origin resume vector could not honor; and it created a second resume-validity path where replication already checks inside the operation (
shouldForceBaseCopyForRetention). The audit retention floor itself still lands in #2458 — write-ahead, monotonic, verified — but as internal infrastructure.Table.subscribeconsumes it inside the resume in harper#2448, and the consumer-facing docs for that behavior belong to #2448.What this reverts: the
### oldestRetainedAuditTime(): numbersection and the reference #660 added to thestartTimerow of the subscription-options table.git revertapplied cleanly against currentmainwith no conflicts; the page is byte-identical to its pre-#660 state in that region.#666, which corrected the removed section's contract wording, is closed for the same reason.
🤖 Generated with Claude Code