Skip to content

Prevent Harper full-text index key collisions - #24

Merged
kylebernhardy merged 1 commit into
mainfrom
codex/issue-11-reclamation
Sep 9, 2026
Merged

Prevent Harper full-text index key collisions#24
kylebernhardy merged 1 commit into
mainfrom
codex/issue-11-reclamation

Conversation

@kylebernhardy

@kylebernhardy kylebernhardy commented Sep 9, 2026

Copy link
Copy Markdown
Member

Introduces an unambiguous, versioned key encoding and durable format validation for Harper-backed Tantivy directories. It rejects the unreleased delimiter-based prototype instead of silently opening a second empty keyspace and records the bounded reclamation delivery sequence for the remaining work in Implement Harper-backed Tantivy Directory mapping and atomic publication #11.

For the human reviewer

  1. Confirm the storage-incarnation boundary: after a clean initial sentinel probe, the directory trusts a valid marker and uses a single-marker-read empty-state cache, assuming Harper restore replaces a closed generation rather than merging older prototype bytes into a live namespace. If Harper permits merge-style restore, this slice needs an explicit create-versus-open contract before the format is released; otherwise the chosen steady state avoids repeated host round trips.

Verification

  • npm run format:check — passed.
  • npm run lint — TypeScript and Clippy passed with warnings denied.
  • npm test — 59 Rust tests, 35 Node tests, and the packed-package consumer test passed; the three opt-in historical rocksdb-js lease tests remained skipped as expected.
  • Read-only Claude and actual Gemini CLI final reviews completed. Gemini reported no actionable findings; Claude retained only the Harper restore-boundary judgment above and the already-documented slice-2 requirement to update the binding equality guard when high-water fields land.

Comment generated by kAIle (GPT-5)

Complexity: complicated

Review-Coverage: authored=codex; ran=claude; declined=gemini,cursor-grok,cursor-composer,domain; rounds=4 @ afb6bcc

Human-Review-Need: 3 @ afb6bcc

@kylebernhardy kylebernhardy added this to the v5.3 milestone Sep 9, 2026
@kylebernhardy
kylebernhardy marked this pull request as ready for review September 9, 2026 15:13
@kylebernhardy
kylebernhardy merged commit b9964b0 into main Sep 9, 2026
6 checks passed
@kylebernhardy
kylebernhardy deleted the codex/issue-11-reclamation branch September 9, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant