Prevent Harper full-text index key collisions - #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces an unambiguous, versioned key encoding and durable format validation for Harper-backed Tantivy directories. It rejects the unreleased delimiter-based prototype instead of silently opening a second empty keyspace and records the bounded reclamation delivery sequence for the remaining work in Implement Harper-backed Tantivy Directory mapping and atomic publication #11.
For the human reviewer
Verification
npm run format:check— passed.npm run lint— TypeScript and Clippy passed with warnings denied.npm test— 59 Rust tests, 35 Node tests, and the packed-package consumer test passed; the three opt-in historical rocksdb-js lease tests remained skipped as expected.Comment generated by kAIle (GPT-5)
Complexity: complicated
Review-Coverage: authored=codex; ran=claude; declined=gemini,cursor-grok,cursor-composer,domain; rounds=4 @ afb6bcc
Human-Review-Need: 3 @ afb6bcc