Protect Harper-backed Tantivy readers during reclamation - #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds process-local object/revision reader pins to the Harper-backed Tantivy Directory so a retained file handle remains visible to the upcoming bounded reclamation consumer. Open-read registration and deletion publication are ordered through a fixed hash-sharded fence without adding storage reads, and the benchmark now measures retained, churned, distinct-file, and shared-file reader behavior.
Progresses #11.
For the human reviewer
Verification
npm run checkpassed: formatting, TypeScript, Clippy, 92 Rust tests, 35 Node tests, and the packed-package test.cargo bench --locked --features phase0 --bench kv_directory -- --smoke --revision reader-pin-finalpassed and emitted the new retained, churned, distinct-file-rw-, and shared-file-rw-reader cases.Comment generated by kAIle (GPT-5)
Complexity: complicated
Review-Coverage: authored=codex; ran=claude; declined=gemini,cursor-grok,cursor-composer,domain; rounds=7 @ 008e2d2
Human-Review-Need: 3 @ 008e2d2