Skip to content

Add bounded reclamation for Harper-backed Tantivy directories - #28

Merged
kylebernhardy merged 6 commits into
mainfrom
codex/issue-11-reclamation-consumer
Sep 10, 2026
Merged

Add bounded reclamation for Harper-backed Tantivy directories#28
kylebernhardy merged 6 commits into
mainfrom
codex/issue-11-reclamation-consumer

Conversation

@kylebernhardy

@kylebernhardy kylebernhardy commented Sep 10, 2026

Copy link
Copy Markdown
Member

Adds a synchronous, budgeted reclamation core for the experimental Harper-backed Tantivy directory. Retired objects drain through durable per-sequence progress while live file handles remain pinned, and terminal corruption is surfaced for generation rebuild rather than silently skipped; review most closely the monotonic tail-snapshot boundary and its deterministic concurrent-enqueue proof.

For the human reviewer

No open judgment calls — independent Claude review converged at efdbf69, and direct Gemini review verified the corrected cursor and tail-hint concurrency paths.

Verification

  • cargo test --locked --all-features: 106 tests passed, including real Tantivy merge, garbage collection, physical drain, crash recovery, and reopen; documentation tests passed.
  • cargo clippy --locked --all-features --all-targets -- -D warnings: passed.
  • npm run test:node: 35 Node/native tests and packed-package verification passed; three pre-existing rocksdb-js opt-in tests skipped because no feature-enabled checkout was configured.
  • cargo bench --locked --features phase0 --bench kv_directory -- --smoke --revision reclamation-consumer-final: passed, including physical reclamation of deleted 4 KiB directory objects.

Complexity: complicated

Comment generated by kAIle (GPT-5)

Review-Coverage: authored=codex; ran=claude; declined=gemini,cursor-grok,cursor-composer,domain; rounds=4 @ efdbf69

Human-Review-Need: 3 @ efdbf69

@kylebernhardy kylebernhardy added this to the v5.3 milestone Sep 10, 2026
@kylebernhardy
kylebernhardy marked this pull request as ready for review September 10, 2026 15:26
@kylebernhardy
kylebernhardy merged commit 585b610 into main Sep 10, 2026
6 checks passed
@kylebernhardy
kylebernhardy deleted the codex/issue-11-reclamation-consumer branch September 10, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant