Add bounded reclamation for Harper-backed Tantivy directories - #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a synchronous, budgeted reclamation core for the experimental Harper-backed Tantivy directory. Retired objects drain through durable per-sequence progress while live file handles remain pinned, and terminal corruption is surfaced for generation rebuild rather than silently skipped; review most closely the monotonic tail-snapshot boundary and its deterministic concurrent-enqueue proof.
For the human reviewer
No open judgment calls — independent Claude review converged at
efdbf69, and direct Gemini review verified the corrected cursor and tail-hint concurrency paths.Verification
cargo test --locked --all-features: 106 tests passed, including real Tantivy merge, garbage collection, physical drain, crash recovery, and reopen; documentation tests passed.cargo clippy --locked --all-features --all-targets -- -D warnings: passed.npm run test:node: 35 Node/native tests and packed-package verification passed; three pre-existing rocksdb-js opt-in tests skipped because no feature-enabled checkout was configured.cargo bench --locked --features phase0 --bench kv_directory -- --smoke --revision reclamation-consumer-final: passed, including physical reclamation of deleted 4 KiB directory objects.Complexity: complicated
Comment generated by kAIle (GPT-5)
Review-Coverage: authored=codex; ran=claude; declined=gemini,cursor-grok,cursor-composer,domain; rounds=4 @ efdbf69
Human-Review-Need: 3 @ efdbf69