Stabilize resilience reload ownership test - #16
Open
remdui wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
reloadConfiguration()deliberately starts a non-blocking health refresh. The concurrency test took its probe-count baseline immediately afterward, so it could observe the in-flight probe after the increment but before its future completed. The later explicit refresh then reused that same future, making the test incorrectly conclude that the replacement resilience registration had been removed.Fix
Drain the reload-triggered health request before recording the baseline. Closing the old slot then happens after a completed baseline probe, and the final explicit request must exercise the replacement runtime control.
Scope
This is test synchronization only. Production reload behavior remains non-blocking, and the ownership invariant being tested is unchanged.