Skip to content

Fix unrelated capacity assignment blocking checkout#1222

Open
realicon23 wants to merge 1 commit into
HiEventsDev:developfrom
realicon23:fix-unrelated-capacity-validation
Open

Fix unrelated capacity assignment blocking checkout#1222
realicon23 wants to merge 1 commit into
HiEventsDev:developfrom
realicon23:fix-unrelated-capacity-validation

Conversation

@realicon23

Copy link
Copy Markdown

Summary

  • Skip overall capacity checks for capacity assignments that have zero selected products in the current checkout request.
  • Add a regression test covering an over-reserved unrelated capacity bucket while the selected product remains available.

Fixes #1195

Tests

  • /opt/homebrew/opt/php@8.4/bin/php vendor/bin/phpunit tests/Unit/Services/Domain/Order/OrderCreateRequestValidationServiceTest.php --no-coverage
  • /opt/homebrew/opt/php@8.4/bin/php -l app/Services/Domain/Order/OrderCreateRequestValidationService.php
  • /opt/homebrew/opt/php@8.4/bin/php -l tests/Unit/Services/Domain/Order/OrderCreateRequestValidationServiceTest.php
  • git diff --check

Note

  • I also ran /opt/homebrew/opt/php@8.4/bin/php vendor/bin/phpunit tests/Unit --no-coverage locally. It completed with 388 passing tests, 2 skipped tests, and 2 failures in Tests

@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@realicon23

realicon23 commented Jun 16, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@realicon23

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@realicon23

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capacity validation blocks unrelated products when one bucket is over-reserved

2 participants