Repository navigation
Add CI support for publishing Windows ARM64 wheels - #14
Open
MugundanMCW wants to merge 1 commit into
Open
MugundanMCW wants to merge 1 commit into
MugundanMCW wants to merge 1 commit into
Conversation
HugoMVale
requested changes
Oct 7, 2026
HugoMVale
left a comment
HugoMVale
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR.
Please have a look at the request below.
| $LlvmBin = 'C:\Program Files\LLVM\bin' | ||
| $LlvmInstaller = "$env:RUNNER_TEMP\LLVM-22.1.8-woa64.exe" | ||
| $LlvmUrl = "https://github.com/llvm/llvm-project/releases/download/llvmorg-$LlvmVersion/LLVM-$LlvmVersion-woa64.exe" | ||
| Invoke-WebRequest $LlvmUrl -UseBasicParsing -OutFile $LlvmInstaller |
Owner
There was a problem hiding this comment.
No hash verification for downloaded binaries (High Risk).
- Lines 7 and 28 download executables and archives without verifying checksums
- An attacker performing a MITM attack or compromising GitHub's release infrastructure could inject malicious code
- Fix: Validate SHA256 hashes against known good values
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: