Apply neutral language framing across documentation and code comments - #767
Draft
jwrosewell wants to merge 1 commit into
Draft
Apply neutral language framing across documentation and code comments#767jwrosewell wants to merge 1 commit into
jwrosewell wants to merge 1 commit into
Conversation
jwrosewell
force-pushed
the
doc-neutral-privacy
branch
from
July 30, 2026 06:07
85d46be to
f3bd521
Compare
lamrowena
reviewed
Jul 30, 2026
| - TCF (Transparency & Consent Framework) | ||
| - Custom consent signals | ||
| - TCF v2 format (the IAB Transparency and Consent Framework encoded string) | ||
| - Global Privacy Platform (GPP) |
Collaborator
There was a problem hiding this comment.
Update to Global Privacy Protocol
lamrowena
reviewed
Jul 30, 2026
| - Custom consent signals | ||
| - TCF v2 format (the IAB Transparency and Consent Framework encoded string) | ||
| - Global Privacy Platform (GPP) | ||
| - US Privacy String |
Collaborator
There was a problem hiding this comment.
I don't think we should include this since support for this is deprecated
bmayd
reviewed
Jul 30, 2026
| //! | ||
| //! Proxies GTM scripts and Google Analytics beacons through the publisher's | ||
| //! domain, improving tracking accuracy and ad-blocker resistance. | ||
| //! domain, improving measurement accuracy and ad-blocker resistance. |
There was a problem hiding this comment.
Perhaps change "ad-block resistance" as well to "integrity"?
bmayd
reviewed
Jul 30, 2026
| @@ -46,7 +46,7 @@ pub const HEADER_REFERER: HeaderName = HeaderName::from_static("referer"); | |||
| /// | |||
| /// These headers are used internally by Trusted Server for identity, geo-enrichment, | |||
There was a problem hiding this comment.
Maybe change "identity" to "identification"?
bmayd
reviewed
Jul 30, 2026
| /// These headers are used internally by Trusted Server for identity, geo-enrichment, | ||
| /// debugging, and compression hints. Leaking them to external origins could expose | ||
| /// user tracking data and internal implementation details. | ||
| /// user identity, geo data, and internal implementation details. |
There was a problem hiding this comment.
Maybe instead of "user identity, geo data," just "data"?
bmayd
reviewed
Jul 30, 2026
|
|
||
| - **Revenue Optimization**: Identify underperforming exchanges, timeout issues, and bid density gaps | ||
| - **Compliance Assurance**: Detect unauthorized calls, consent violations, and policy breaches | ||
| - **Policy Monitoring**: Detect calls outside the configured allowlist, consent mismatches, and policy breaches |
There was a problem hiding this comment.
Change "policy breaches" to "policy issues"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Privacy is a spectrum, not a binary. Trusted Server is technology, and it is neutral on policy. Different deployers operate under different laws and run different policies, and it is the deployer who decides how to configure the stack accordingly. Trusted Server's role is to give deployers the flexibility to make those choices and to respect those choices when made, rather than to limit them in the deployer's name. This change updates documentation and code comments to reflect that framing.
Wording such as "privacy-preserving" identifiers, "built-in GDPR compliance", and "privacy-first" design presents privacy as a property of the technology itself. That overstates what software can promise, understates the role of the deployer, and asks the reader to accept a policy position in order to accept a technical description.
What changed
x-ts-ecas an inbound transport when it is a response header. The placeholder secret causes a settings load failure rather than a logged warning. Consent gating is built in per jurisdiction, with configuration tuning jurisdiction lists, GPC interpretation, and conflict resolution.Scope
No runtime behavior changes. Code edits are limited to comments, doc comments, and test assertion message strings.
An audit worksheet and a followups plan under
docs/superpowers/plans/record the findings, the rewrites, and the items intentionally deferred to a separate code cycle (behavior questions and symbol renames that are out of scope for a wording change).