-
Notifications
You must be signed in to change notification settings - Fork 12
Support per-section GAM ad unit paths via gam_unit_path templates #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prk-Jr
wants to merge
14
commits into
main
Choose a base branch
from
954-per-section-gam-unit-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f59fd85
Add gam_unit_path template parser
prk-Jr 9a71f55
Add request-path section derivation
prk-Jr 7575873
Add section_root, unit-template compile/render, and startup validation
prk-Jr 860ed0b
Render gam_unit_path template per request across initial and SPA paths
prk-Jr 21a3523
Add spec and plan for per-section gam_unit_path
prk-Jr 070fd94
Document per-section gam_unit_path templating
prk-Jr 20f5f8e
Use fictional example values in tests and docs
prk-Jr dbdaea7
Merge branch 'main' into 954-per-section-gam-unit-path
prk-Jr f0a275b
Address review feedback on gam_unit_path templating
prk-Jr bfc1cb9
Merge remote-tracking branch 'origin/954-per-section-gam-unit-path' i…
prk-Jr 92faf6b
Merge branch 'main' into 954-per-section-gam-unit-path
prk-Jr 4bedcd7
Address review feedback on per-section gam_unit_path
prk-Jr 367dc04
Fix doc lint
prk-Jr 7c9d4f4
Merge branch 'main' into 954-per-section-gam-unit-path
prk-Jr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
736 changes: 702 additions & 34 deletions
736
crates/trusted-server-core/src/creative_opportunities.rs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 P3 — Documentation still contains the pre-
section_segmentdescriptionThis table says
{section}is always the first path segment, while the implementation and the following section use the configured segment. Related rustdoc increative_opportunities.rsalso describes outdated first-segment and compiled-only behavior.Please also update the
section_rootfield docs and clarify that raw-template fallback enforces thesection_rootrequirement even without the cache, while compilation remains required to reject malformed templates.