Prevent duplicate GPT slot requests - #966
Open
ChristianPavilonis wants to merge 5 commits into
Open
Conversation
prk-Jr
added a commit
that referenced
this pull request
Jul 27, 2026
googletag.display()/refresh() may pass a Slot object rather than a string id, which made elementId.startsWith throw and abort the GPT command queue — no ads requested. Coerce a non-string arg to its getSlotElementId() (empty string if unresolvable) before the string matching, keeping the gate-publisher-requests feature intact (rather than reverting it as #966 did). Applied to the inline bootstrap (gpt_bootstrap.js) and the bundle twin (gpt/index.ts).
ChristianPavilonis
requested review from
aram356 and
prk-Jr
and removed request for
aram356
July 27, 2026 15:43
ChristianPavilonis
marked this pull request as ready for review
July 27, 2026 15:43
aram356
self-requested a review
July 28, 2026 05:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
crates/trusted-server-js/lib/src/integrations/gpt/index.tscrates/trusted-server-js/lib/src/core/types.tswindow.tsjshandoff lifecycle state.crates/trusted-server-core/src/integrations/gpt_bootstrap.jscrates/trusted-server-js/lib/test/integrations/gpt/ad_init.test.tsdisableInitialLoad().crates/trusted-server-core/src/integrations/gpt.rsdocs/superpowers/{specs,plans}/Closes
Closes #944
Test plan
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute servecargo test-axum; target-matchedtrusted-server-coreGPT tests;cargo clippy-axumChecklist
unwrap()in production code — useexpect("should ...")tracingmacros (notprintln!)