Repository navigation
Updated cpex dependency to 1.0.4+ - #186
Merged
Merged
Conversation
Signed-off-by: cafalchio <mcafalchio@gmail.com>
cafalchio
requested review from
gandhipratik203,
lucarlig and
msureshkumar88
as code owners
September 19, 2026 11:10
cafalchio
marked this pull request as draft
September 19, 2026 11:10
Signed-off-by: cafalchio <mcafalchio@gmail.com>
cafalchio
marked this pull request as ready for review
September 19, 2026 11:25
cafalchio
marked this pull request as draft
September 19, 2026 11:25
Signed-off-by: cafalchio <mcafalchio@gmail.com>
cafalchio
marked this pull request as ready for review
September 21, 2026 15:46
gandhipratik203
approved these changes
Sep 22, 2026
gandhipratik203
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Necessary cpex update for 2.0.
msureshkumar88
approved these changes
Sep 22, 2026
msureshkumar88
left a comment
Collaborator
There was a problem hiding this comment.
Verified against the actual diff and resolved lockfiles (uv.lock: cpex 0.1.3→0.1.4, mcp 1.29.1→2.2.0). No blocking issues — approving. A few non-blocking follow-ups worth picking up:
mcp>=2.0.0has no upper bound, inpyproject.tomland all 8 Rust-pluginpyproject.tomlfiles. Every other major-sensitive dep in the same file is bounded (pydantic<3,maturin<2.0,cpex<0.2). Worth matching that convention (mcp>=2.0.0,<3) so a futureuv lock --upgradecan't silently pull inmcp3.x.- PR title/description say "cpex 1.0.4" — actual bump is
cpex>=0.1.4,<0.2(0.1.4, not 1.0.4). Cosmetic, but worth fixing for changelog/search clarity. [tool.uv.exclude-newer-package] cpex = "2026-09-19T23:59:59Z"is an absolute-date exception against the rollingexclude-newer = "10 days"window. Needed today, but once the rolling window passes this date (~2026-09-29) it flips from permissive to more restrictive than default, silently blocking future cpex releases. A removal-date comment or follow-up ticket would help.- Cargo.lock carries ~59 lines of unrelated transitive Rust crate bumps (clap, syn, rustls, wasm-bindgen, etc.) with no Rust crate named
cpex. Optional to split out for cleaner bisect history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated dependency on cpex 1.0.4 to allow cf to update SDK.