Repository navigation
feat(rate-limiter): add per-server user limits - #198
Merged
Merged
Conversation
Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
vishu-bh
requested review from
gandhipratik203,
lucarlig and
msureshkumar88
as code owners
October 5, 2026 21:12
Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
by_user_per_serverrate limits keyed by user and MCP serverby_useras the global per-user ceiling across serversby_tenantas an optional shared infrastructure ceilingWhy
A shared tenant bucket does not provide fair allocation between users. One user can consume nearly all shared capacity. The new dimension gives every user an independent allowance for each server while preserving the existing global user limit.
Testing
cargo test -p rate_limiter— 89 passedcargo clippy -p rate_limiter --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkThe umbrella integration run reached the existing Redis TLS fixture but could not complete locally because its generated certificate was rejected for a missing Authority Key Identifier. The focused feature suites and real Redis isolation test pass.
Closes #172.