fix: resolve npx double package install failure - #848
Open
Andris28 wants to merge 11 commits into
Open
Conversation
Signed-off-by: András Felleg <afelleg@gmail.com>
Signed-off-by: András Felleg <afelleg@gmail.com>
Signed-off-by: András Felleg <afelleg@gmail.com>
Signed-off-by: András Felleg <afelleg@gmail.com>
Signed-off-by: András Felleg <afelleg@gmail.com>
Signed-off-by: András Felleg <afelleg@gmail.com>
Andris28
changed the title
Andris28
marked this pull request as ready for review
August 10, 2026 08:44
12 tasks
Signed-off-by: András Felleg <afelleg@gmail.com>
Signed-off-by: András Felleg <afelleg@gmail.com>
Signed-off-by: András Felleg <afelleg@gmail.com>
pyrooka
requested changes
Aug 12, 2026
pyrooka
left a comment
pyrooka
left a comment
Member
There was a problem hiding this comment.
I left a few things to address/discuss. Otherwise, the changes look good!
Comment on lines
+79
to
+80
| # Test without a custom ruleset | ||
| npx --yes \ |
Member
There was a problem hiding this comment.
Adding the --prefer-online flag would be helpful to avoid reusing stale cached data. According to the NPM docs it does the following:
If true, staleness checks for cached data will be forced, making the CLI look for updates immediately even for fresh package data.
Suggested change
| # Test without a custom ruleset | |
| npx --yes \ | |
| # Test without a custom ruleset | |
| npx --yes --prefer-online \ |
| @@ -0,0 +1,30 @@ | |||
| /** | |||
| * Copyright 2017 - 2025 IBM Corporation. | |||
Member
There was a problem hiding this comment.
Suggested change
| * Copyright 2017 - 2025 IBM Corporation. | |
| * Copyright 2026 IBM Corporation. |
| * SPDX-License-Identifier: Apache2.0 | ||
| */ | ||
|
|
||
| 'use strict'; |
Member
There was a problem hiding this comment.
I think we don't need to use strict mode here. Actually we don't really use it anymore if you check any of the recent files.
Comment on lines
+10
to
+12
| const validatorPkg = require('../../../package.json'); | ||
| const rulesetPkg = require('../../../../ruleset/package.json'); | ||
| const spectralRulesetsPkg = require('../../../../../node_modules/@stoplight/spectral-rulesets/package.json'); |
Member
There was a problem hiding this comment.
These relative paths look a bit fragile. Do you think something like this would work?
const spectralRulesetsPkg = require(
require.resolve('@stoplight/spectral-rulesets/package.json')
);
Signed-off-by: András Felleg <afelleg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
In this commit we fix an issue where installing the
validator with npx would cause ruleset is not an object
failure, due to spectral core version mismatch.
PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:
.secrets.baselinehas been updated as needednpm run update-utilitieshas been run if any files inpackages/utilities/srchave been updatedChecklist for adding a new validation rule: