Repository navigation
Course: Change col target_group to type text in table crs_settings - #12021
Merged
Merged
Conversation
alex40724
approved these changes
Sep 18, 2026
alex40724
requested review from
schmitz-ilias
and removed request for
smeyer-ilias
September 18, 2026 12:17
Member
|
@schmitz-ilias Can you ask Stefan for the ok here. For me this looks good. |
schmitz-ilias
approved these changes
Sep 24, 2026
schmitz-ilias
left a comment
schmitz-ilias
left a comment
Contributor
There was a problem hiding this comment.
I've had a look with @smeyer-ilias, and the changes look good to us. Thanks for pushing the move to mb4 @lscharmer!
Contributor
Author
Hi @schmitz-ilias, @smeyer-ilias & @alex40724, Thanks a lot & best |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem in the
eventtable when migrating fromutf8mb3toutf8mb4.Currently the table cannot be converted to
utf8mb4because the row size would be to large:With utf8mb4 4 bytes per char instead 3 are reserved, so each (var-)char field length is multiplied by 4 instead 3.
It is enough to change one
varchar(4000)field to typetextto fit into the row size limit.This PR is in preparation for an upcoming PR to change the Database charset & collation from
utf8mb3toutf8mb4.