Skip to content

Ensure json query output is valid json - #343

Merged
jaredclaypoole merged 1 commit into
IMAP-Science-Operations-Center:mainfrom
jaredclaypoole:fix-query-json
Aug 5, 2026
Merged

Ensure json query output is valid json#343
jaredclaypoole merged 1 commit into
IMAP-Science-Operations-Center:mainfrom
jaredclaypoole:fix-query-json

Conversation

@jaredclaypoole

Copy link
Copy Markdown
Contributor

Closes issue #342

Change Summary

  • Ensure query output is converted to a valid json string before printing
  • Delete outdated comment
  • Add a test ensuring the cli query's output is valid and expected json

* Also add a validating test

@tmplummer tmplummer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@tech3371 tech3371 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good!

@tmplummer

Copy link
Copy Markdown
Contributor

@jaredclaypoole, Assuming you have the right permissions, feel free to merge a PR once you have an approving review.

@jaredclaypoole
jaredclaypoole merged commit 69e40ff into IMAP-Science-Operations-Center:main Aug 5, 2026
16 checks passed
@jaredclaypoole
jaredclaypoole deleted the fix-query-json branch August 5, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants