webpoda query update to support S/C time - #345
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the WebPODA raw packet download flow to support selecting spacecraft-date ranges directly (SCT mode) while retaining the prior Earth-received-time-driven behavior (ERT mode), and wires this selection into the CLI.
Changes:
- Added a
--query-modeflag to thewebpodaCLI command to choose betweenertandsctquery behavior. - Updated
download_daily_data()to branch behavior based onquery_by_ert, deriving the set of spacecraft dates either from ERT packet timestamps or from the requested SCT date range. - Updated WebPODA-related help text and logging/docstrings to reflect the new query behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| imap_data_access/webpoda.py | Adds ERT vs SCT branching for computing daily query dates; adjusts related messaging/docstrings. |
| imap_data_access/cli.py | Adds --query-mode to the webpoda subcommand and passes it through to the download function; improves command description/help. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tmplummer
left a comment
There was a problem hiding this comment.
This looks good to me. I think we should write a ticket for adding ENA+GLOWS support by supporting instruments that break data up by repoint.
Ticket sounds good to me for ENA and GLOWS because I tried to look into adding their support and it is more involved than I was prepared for. |
57344d9
into
IMAP-Science-Operations-Center:main
Change Summary
Overview
I started this change to support query by S/C time that falls within input date range. and keep ERT support still. I am hoping this will support discussion about webpoda update and future path.
File changes
Testing