Skip to content

webpoda query update to support S/C time - #345

Merged
tech3371 merged 3 commits into
IMAP-Science-Operations-Center:mainfrom
tech3371:webpoda-query-update
Aug 13, 2026
Merged

webpoda query update to support S/C time#345
tech3371 merged 3 commits into
IMAP-Science-Operations-Center:mainfrom
tech3371:webpoda-query-update

Conversation

@tech3371

Copy link
Copy Markdown
Contributor

Change Summary

Overview

I started this change to support query by S/C time that falls within input date range. and keep ERT support still. I am hoping this will support discussion about webpoda update and future path.

File changes

Testing

@tech3371 tech3371 self-assigned this Aug 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the WebPODA raw packet download flow to support selecting spacecraft-date ranges directly (SCT mode) while retaining the prior Earth-received-time-driven behavior (ERT mode), and wires this selection into the CLI.

Changes:

  • Added a --query-mode flag to the webpoda CLI command to choose between ert and sct query behavior.
  • Updated download_daily_data() to branch behavior based on query_by_ert, deriving the set of spacecraft dates either from ERT packet timestamps or from the requested SCT date range.
  • Updated WebPODA-related help text and logging/docstrings to reflect the new query behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
imap_data_access/webpoda.py Adds ERT vs SCT branching for computing daily query dates; adjusts related messaging/docstrings.
imap_data_access/cli.py Adds --query-mode to the webpoda subcommand and passes it through to the download function; improves command description/help.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread imap_data_access/webpoda.py Outdated
Comment thread imap_data_access/webpoda.py Outdated
Comment thread imap_data_access/cli.py

@tmplummer tmplummer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think we should write a ticket for adding ENA+GLOWS support by supporting instruments that break data up by repoint.

@tech3371
tech3371 marked this pull request as ready for review August 13, 2026 14:43
@tech3371

Copy link
Copy Markdown
Contributor Author

This looks good to me. I think we should write a ticket for adding ENA+GLOWS support by supporting instruments that break data up by repoint.

Ticket sounds good to me for ENA and GLOWS because I tried to look into adding their support and it is more involved than I was prepared for.

@tech3371
tech3371 merged commit 57344d9 into IMAP-Science-Operations-Center:main Aug 13, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants