Card 3098 - Maps: Remove nominal survival probability logic - #164
Open
pleasant-menlo wants to merge 1 commit into
Open
Card 3098 - Maps: Remove nominal survival probability logic#164pleasant-menlo wants to merge 1 commit into
pleasant-menlo wants to merge 1 commit into
Conversation
…al probability when there is missing GLOWS data. Now when there is missing GLOWS data the corresponding L1c data will just not be projected into the map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#60 Removed fallback to 1.0 for survival probability when there is missing GLOWS data.
Now when there is missing GLOWS data the corresponding L1c data will just not be projected into the map
Note: this was mostly a revert of 9d19c54a3202794d2fc6753e9c09085108ef6f80, except that commit had also removed logic that prevented maps from being generated until there was a GLOWS file after the end date of the map. I did not bring that logic back as we will probably want to generate maps even if we don't have GLOWS data after the end date of the map depending on how progressive maps are implemented.
~ SWYN