sammi-cdf: missing LABAXIS label in CoDICE L2 Hi and Lo YAML files - #3381
Merged
leowerneck merged 3 commits intoAug 12, 2026
Merged
Conversation
tmplummer
reviewed
Aug 12, 2026
tmplummer
left a comment
tmplummer
left a comment
Contributor
There was a problem hiding this comment.
I think that we need to check with CoDICE to confirm that removing LABL_PTR_1 is correct. See my comment on the change.
leowerneck
changed the title
leowerneck
force-pushed
the
lw/issue3379
branch
from
August 12, 2026 19:40
df131ff to
232a50b
Compare
tmplummer
approved these changes
Aug 12, 2026
tmplummer
left a comment
tmplummer
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the update... I actually would be interested to know what the instrument team wants from the CDAWeb plot but that doesn't need to be addressed here.
leowerneck
merged commit Aug 12, 2026
fa98aab
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Closes #3379.
Overview
This PR fixes errors in CoDICE direct-events metadata that were not caught by
sammi-cdf==1.0.0. To increase robustness of the CI, the project's dependency was updated to use only versions ofsammi-cdfthat have the correct behavior (>=1.0.2,<2).File changes
imap_processing/cdf/config/imap_codice_l2-hi-direct-events_variable_attrs.yamlLABLAXIS: Number of Eventsimap_processing/cdf/config/imap_codice_l2-lo-direct-events_variable_attrs.yamlLABLAXIS: Number of Eventsimap_processing/tests/cdf/test_imap_cdf_manager.pyLABAXISattribute.poetry.locksammi-cdfversion.pyproject.tomlsammi-cdfversion.