Repository navigation
Revert sign-up use cases pushed to develop without review - #501
Merged
Merged
Conversation
The sign-up use cases (3f94643) and a merge of develop into that branch (6c09046) were pushed straight to develop by mistake, without review. Their integration tests call /api/users/signup, which only exists in the unmerged IQSS/dataverse#12858, so develop's CI fails. This restores develop to 4281c37. The change will come back through its own pull request.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reverts two commits that were pushed straight to
developby mistake, without a pull request:3f94643bfeat: add sign-up and ORCID-at-sign-up use cases6c09046cMerge branch 'develop' into builtin-user-signup-and-orcidTheir integration tests call
/api/users/signup, which only exists in the unmerged IQSS/dataverse#12858. Because of that,develop'sdeploy_alpharun fails (no alpha was published).After this PR,
develophas exactly the same files as4281c372(Merge pull request #413). The sign-up use cases will come back through their own draft PR for review.Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
The revert is a single commit (
git revert -m 2 6c09046c).git diff 4281c372 HEADis empty.Suggestions on how to test this:
CI on this PR should pass, with no sign-up tests running.
Is there a release notes or changelog update needed for this change?:
No. The sign-up
CHANGELOG.mdentry is removed along with the code and comes back with the new PR.Additional documentation:
None.