Scroll to first missing metadata error - #12634
Open
qqmyers wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds a simple update to scroll to the first missing metadata error when a required field is not filled in.
Which issue(s) this PR closes:
Special notes for your reviewer: Should handle first view of the metadata edit page as well as when 'save' is hit.
Suggestions on how to test this: - Leave required metadata empty and hit save, e.g. create a dataset w/o entering anything (so missing title), or delete the contact email in an existing dataset. Can also create an incomplete dataset via the api (when enabled) and go to the dataset page and edit.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: just scrolls, changes top message to Required fields were missed or there was a validation error. See details below. since it now auto scrolls.
Is there a release notes update needed for this change?:
Additional documentation: