12633 - Don't show submitted for review to guest users - #12635
Open
qqmyers wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Per the issue, recent changes caused the Submitted For Review menu item to be shown when a draft of a published dataset was in that state, regardless of permission. This PR removes the or latestVersionInReview condition in the render attributes that caused this.
Which issue(s) this PR closes:
Special notes for your reviewer: I investigated #12266 some, and didn't see anything that required additional this condition, but may have missed something.
Suggestions on how to test this: Create and publish a dataset, create a draft version and submit it for review. The user who did that should see the Submitted For Review disabled menu entry, but Guest Users should not (only those who could submit for review, return to author, etc. as in the other render clauses.) Any testing for #12266 related to this menu should probably also be repeated.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: