Fix race - #6
Open
Tom-Willemsen wants to merge 1 commit into
Open
Conversation
Tom-Willemsen
force-pushed
the
fix_race
branch
from
August 11, 2026 14:33
e38f30a to
227889b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was failing due to subtle timing differences on a branch using ISISComputingGroup/lewis#336 .
I don't think this is the fault of the lewis emulator in this case - it is just some marginal race condition that the new asyncio-based code falls on the wrong side of.
The only 'regression' caused by this change is that the test might take up to 2s longer to execute.
To test this:
python -m pip install git+https://github.com/ISISComputingGroup/lewis@c79836a93d62b93a5a43a3398d664b246e975b31run_tests.bat-tests.keithley_2290.Keithley2290DeviceTests.test_WHEN_setting_volt_beyond_volt_limitwill probably fail