[WIP] Operand-driven diagonal algebra for the dense path - #224
Draft
mtfishman wants to merge 1 commit into
Draft
Conversation
Preserve the Diagonal type through the operations whose result is genuinely diagonal: factorizations return the spectrum bare, unmatricize keeps the (1,1) endomorphism split, and single-contracted-leg Diagonal times Diagonal stays Diagonal. Densify only where the result is not representable as a Diagonal.
2 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 80.05% 76.12% -3.94%
==========================================
Files 28 27 -1
Lines 1038 1043 +5
==========================================
- Hits 831 794 -37
- Misses 207 249 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make diagonal algebra operand-driven on the dense path: an operation keeps the
Diagonaltype when its result is genuinely diagonal and densifies otherwise. Companion to ITensor/GradedArrays.jl#264.TODO
0.20.1, or supersede0.20.0).