Repository navigation
Conversation
Seed ended rooms 30 days before today, inside the one-year window. Add a test that rooms ended over a year ago stay hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
AnonymousLeaderboardJooqAdapterhides an ENDED room onceended_at + interval '1 year'is no longer after the database clock. Four persistence test classes seeded ENDED rooms on fixed 2026 dates, so 16 of their 17 tests would fail from 2027-08-02 (2027-08-10 for the settlement test).Each test timeline now starts 30 days before today (UTC) at its original time of day, so the seeded rooms always end inside the window. A new test checks that public rooms, and secret rooms with access granted, stay hidden once they ended more than a year ago. Production code is unchanged.
Verification
./gradlew test --no-daemon --parallel --no-build-cache: the only failures are 2 inAccountClosurePersistenceIntegrationTest. With that fix applied as well: 1055 tests, 0 failures, 1 existing skip.Related: #294 (the AccountClosure fix; merge it first).