Repository navigation
Conversation
A lone option reached getFirst() on an empty command list and exited 70. Options without a command are now usage errors (exit 2).
The .sha256 held the runner path, so the documented sha256sum -c failed next to the downloaded archive.
A cli-vX.Y.Z tag now builds idea2strategy-X.Y.Z.zip, and --version reports X.Y.Z, instead of every release shipping 0.1.0-SNAPSHOT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
idea2strategy --helpor--versionreachedgetFirst()on an empty command list and exited 70. Both now answer in the usual JSON envelope, and an option with no command is a usage error (exit 2)..sha256recorded the runner path, so the documentedsha256sum -cfailed next to the downloaded archive. It now names only the archive.0.1.0-SNAPSHOT. Acli-vX.Y.Ztag now buildsidea2strategy-X.Y.Z.zip, and--versionreportsX.Y.Z; a tag that is notcli-vX.Y.Zfails the workflow.Verified
./gradlew :apps:idea2strategy-cli:test: 30 tests, 0 failures../gradlew :apps:idea2strategy-cli:distZip -PcliVersion=1.2.3builtidea2strategy-1.2.3.zip; the unzipped launcher answered--versionwith1.2.3,--helpwith exit 0,--boguswith exit 2, andshasum -a 256 -cpassed on a bare-name checksum.cli-v1.2.3andcli-v1.2.3-rc.1and rejectsv1.2.3andcli-v1.2.bash scripts/test-github-actions-pins.sh: 7 immutable references verified../gradlew test: 1058 tests, 1 skipped, 2 failed; both are theAccountClosurePersistenceIntegrationTestwall-clock failures fixed by test(account): pin legal hold applied_at #294.Checklist