Skip to content

fix(backtest): annotate scalar_one results #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kcrmin wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(backtest): annotate scalar_one results #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/backtest_engine/backtest_request_intake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ def claim(
)
return RequestClaim(RequestClaimDisposition.CLAIMED)

latest = connection.execute(
latest: int = connection.execute(
text(
"""
SELECT COALESCE(MAX(o.aggregate_sequence), 0)
Expand Down
2 changes: 1 addition & 1 deletion tests/persistence/test_money_precision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def test_numeric_24_8_round_trips_without_precision_loss(persistence: BacktestPe
with persistence.unit_of_work() as uow:
stored = uow.runs.get(row.id).initial_cash_amount
# `==` on Decimal ignores trailing zeros, so read the stored digits as text too.
stored_text = uow.connection.execute(
stored_text: str = uow.connection.execute(
text("SELECT initial_cash_amount::text FROM backtest.runs WHERE id = :id"),
{"id": str(row.id)},
).scalar_one()
Expand Down
2 changes: 1 addition & 1 deletion tests/persistence/test_runtime_no_ddl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,6 @@ def test_ddl_really_did_not_happen(persistence: BacktestPersistence, admin_engin
uow.connection.execute(text("CREATE TABLE backtest.sneaky (id uuid PRIMARY KEY)"))

with admin_engine.connect() as connection:
exists = connection.execute(text("SELECT to_regclass('backtest.sneaky') IS NOT NULL")).scalar_one()
exists: bool = connection.execute(text("SELECT to_regclass('backtest.sneaky') IS NOT NULL")).scalar_one()

assert exists is False
Loading