Repository navigation
Conversation
Testcontainers starts every container the docker suites use, so the service containers and their fixed endpoint variables went unread.
macOS rejects setrlimit(RLIMIT_AS), so the forked probe died and the unit suite failed on every Mac. Linux CI still runs it.
gate3 measured coverage but enforced nothing. 77 is today's CI total (77.6%) rounded down, so the gate can only ratchet upward.
httpx2 exists, and starlette.testclient prefers it over httpx.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
BACKTEST_TEST_SQS_ENDPOINT/LOCALSTACK_ENDPOINT_URLvariables. Nothing readsthem:
tests/conftest.pyandtests/test_object_store.pystart their ownLocalStack through Testcontainers. The comments now say that. Job names are
unchanged, so required checks keep matching.
--cov-fail-under=77. CI measures 77.6% today (statements plusbranches, from the develop and build(deps): cap sqlalchemy below 2.2 #103 coverage artifacts), rounded down.
data-pipeline holds 88, so the floor should only go up.
pyproject.toml: the comment saidhttpx2does not exist. It does, andstarlette.testclient prefers it. No dependency change: the fallback to
httpxonly warns, nothing imports
httpxdirectly, and httpx2 shipped four releasesin the last ten days. Swapping it in is a separate bump once a release has aged.
test_monitor_names_the_enforcement_mechanism_actually_in_forceis skipped onmacOS, where
setrlimit(RLIMIT_AS)raisesValueError. Linux CI still runs it.Verified
pytest -m "not docker" ... --cov-fail-under=77(macOS): 1418 passed,2 skipped, total 77.55%
pytest -m dockerwith no service on port 4566: 241 passed, 0 skippedactionlint 1.7.12,ruff check,ruff format --check: cleanmypy(gate2) fails on develop itself under SQLAlchemy 2.1, with the threescalar_oneannotations that #102 adds. This PR does not touch them.Checklist