Skip to content

chore(operator): remove oidc-era leftovers - #188

Open
kcrmin wants to merge 7 commits into
developfrom
chore/remove-operator-oidc-leftovers
Open

kcrmin wants to merge 7 commits into
developfrom
chore/remove-operator-oidc-leftovers

Conversation

@kcrmin

@kcrmin kcrmin commented Oct 27, 2026

Copy link
Copy Markdown
Member

What and why

Operators now sign in with opaque cookie sessions, but several pieces from the earlier OIDC/bearer design and the removed workflow harness were still in the repo with nothing using them:

  • docs/OPERATOR_OIDC_DEPLOYMENT.md documented build inputs and an e2e:operator-oidc script that no longer exist
  • MOCK_IDP_PORT/MOCK_IDP_URL in e2e/ports.ts and the operator-oidc.e2e.ts ignore in playwright.config.ts
  • src/lib/operatorLocalHarness.ts (+ test) and the VITE_ENABLE_LOCAL_OPERATOR_HARNESS flag set for the mock e2e server: no module imports the bridge and no code reads the flag
  • createAdminMcpClient/defaultAdminMcpClient in accountOperations.ts (+ tests): no screen invokes Admin MCP tools from the browser, so VITE_ADMIN_MCP_BASE_URL is no longer read either
  • start.cmd, which launched Vite from a machine-specific runtime path (pnpm dev is the documented entry)
  • .harness/commands.yaml and its .gitignore rules, left over from the removed harness workflow

The README real-API section also described a fixed backend/root revision pair and sibling a23-real-* checkouts. It now matches e2e/realApiGlobalSetup.ts: the parent root checkout and ../backend by default, backend pinned to the root gitlink, seeds, readiness timeout, Gradle cache options and the external full-stack mode.

Root workflows still pass VITE_ADMIN_MCP_BASE_URL='' to pnpm build; that is now a no-op and can be dropped in a later root change.

Verified

  • git grep finds no remaining reference to the removed symbols, files, env flags or ports
  • node --test scripts/test-github-action-pins.mjs scripts/test-real-api-integration-workflow.mjs: 2 passed
  • pnpm typecheck: clean
  • pnpm exec vitest run (Node 24): 57 files, 683 tests passed
  • pnpm build && node scripts/assert-production-bundle.mjs: passed; built assets contain no mcp/v1 or operatorAccessToken
  • CI=1 pnpm e2e (Node 24): 26 passed
  • CI=1 pnpm e2e:operator-session: 1 passed

Checklist

  • Only unused code, config and docs removed; no behavior change
  • Operator cookie-session flows still covered by e2e
  • README real-API steps checked against the global setup
  • No secrets or ports changed

Operators sign in with cookie sessions now; the PKCE/OIDC build inputs
and the e2e:operator-oidc script it documents no longer exist.
The operator OIDC e2e suite and its mock identity provider are gone;
remove the leftover port constants and the playwright ignore entry.
Nothing reads VITE_ENABLE_LOCAL_OPERATOR_HARNESS or imports the
token bridge; operators use cookie sessions.
No screen invokes Admin MCP tools from the browser; drop the client,
its default instance and the VITE_ADMIN_MCP_BASE_URL read.
start.cmd launched Vite from a private runtime path; pnpm dev is
the documented way to start the UI.
The workflow harness that read .harness/commands.yaml was removed;
drop the file and its ignore rules.
Describe the default sibling checkouts, gitlink revision check, seeds,
cache options and the external full-stack mode the setup really uses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant