Repository navigation
Conversation
Also refresh postcss, nanoid and source-map-js within their ranges to clear the vite toolchain advisories.
Clears the vitest and @vitest/mocker path traversal advisory.
jsdom 30 depends on undici 8, which clears every undici advisory reported against the jsdom 29 tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
pnpm auditondevelopreports 30 advisories (8 high, 18 moderate, 4 low), all in the build and test toolchain:vite8.1.5 (launch-editor existence check and related), pluspostcss,nanoidandsource-map-jsunder itvitest/@vitest/mocker4.1.10 (path traversal)undici7.28.0 underjsdom29.1.1 (18 advisories, fixed only in 7.30.1+)Changes, one commit each:
vite8.1.5 -> 8.1.6, refreshingpostcss8.5.31,nanoid3.3.20 andsource-map-js1.2.2 within vite's ranges (the refresh also moved@testing-library/dom's@babel/runtimeto 7.29.10)vitest4.1.10 -> 4.1.12 (all@vitest/*follow)jsdom29.1.1 -> 30.1.3, which moves toundici8.12.3 and clears every undici advisory. jsdom 30 needs Node^24.15.0; CI andenginesalready use Node 24.Remaining audit
pnpm auditafter this branch: 1 highreact-router7.18.1 (viareact-router-dom): RSC Mode CSRF bypass, patched in 7.18.2. The app does not use RSC mode; left for a separate runtime-dependency bump since it ships in the bundle.Verified
All on Node 24.22.1:
pnpm install --frozen-lockfile: cleannode --test scripts/test-github-action-pins.mjs scripts/test-real-api-integration-workflow.mjs: 2 passedpnpm typecheck: cleanpnpm exec vitest run: 58 files, 688 tests; green on reruns. The only failures seen were the two known focus races fixed by fix(competition): keep dialog focus on re-render #185 and test(strategy): wait for frame-deferred cap focus #186, which fail just as often ondevelop(isolated run of the two files: 6/6 ondevelop, 5/6 here). With fix(competition): keep dialog focus on re-render #185 and test(strategy): wait for frame-deferred cap focus #186 applied on top, 6/6 isolated runs and 3/3 full runs passed (689 tests)pnpm build && node scripts/assert-production-bundle.mjs: passedCI=1 pnpm e2e: 26 passedCI=1 pnpm e2e:operator-session: 1 passedpnpm audit: 30 -> 1 advisoryChecklist
--frozen-lockfileRelated: #185, #186