Skip to content

fix: builtins/publish: keep xs+xsi NS in cleanup #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vladimir-mencl-eresearch wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: builtins/publish: keep xs+xsi NS in cleanup #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16d016e
fix: builtins/publish: keep xs+xsi NS in cleanup
vladimir-mencl-eresearch Sep 3, 2026
a2b3dfc
fix: move namespace cleanup to source
vladimir-mencl-eresearch Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/pyff/builtins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,10 +552,6 @@ def _nop(x):
out = output_file
data = req.t

# clean unused namespaces - the working document isn't always XML (eg discojson* produce JSON)
if isinstance(data, (etree._Element, etree._ElementTree)):
etree.cleanup_namespaces(data)

if not req.args.get('raw'):
data = dumptree(req.t, pretty_print=req.args.get('pretty_print'))

Expand Down
6 changes: 6 additions & 0 deletions src/pyff/samlmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,12 @@ def entitiesdescriptor(
ent_insert = deepcopy(ent_insert)
t.append(ent_insert)

# clean unused namespaces
# Keep xs: and xsi:, as these are crucial - and xs: is used only
# in attribute values, so may appear as unused.
keep_ns_prefixes = ['xs', 'xsi']
etree.cleanup_namespaces(t, keep_ns_prefixes=keep_ns_prefixes)

if config.devel_write_xml_to_file:
import os

Expand Down
Loading