Repository navigation
fix(splitter): keep the focused bar above positioned pane content - #2567
Merged
Merged
Conversation
- Give each pane its own stacking context and drop the z-index of the focused bar from 99 to 1. Slotted content with any z-index now stays under the focus ring. Before, content with a z-index of 99 or more could cover it. - Add a spec that mounts every defined tag in each theme and checks that the parts with a z-index stay under an earlier page layer.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the splitter focus-ring stacking change.
No open issues 🎉
What changed in this PR
This PR fixes splitter focus-ring visibility by containing pane content in separate stacking contexts, keeping high-z-index content below the focused bar.
Changes:
- Isolate each pane and reduce the focused bar’s z-index from 99 to 1.
- Add a splitter regression test and cross-component, cross-theme stacking-containment tests.
- Update the splitter specification and changelog to document the behavior.
| File | Description |
|---|---|
src/components/z-index-containment.spec.ts |
Adds page-layer containment checks across defined tags and themes. |
src/components/splitter/themes/splitter.base.scss |
Gives each pane its own stacking context. |
src/components/splitter/themes/shared/splitter.common.scss |
Lowers the focused bar’s z-index to 1. |
src/components/splitter/splitter.spec.ts |
Tests the focused bar above fixed, high-z-index pane content. |
src/components/splitter/spec.md |
Documents focus-ring containment and the regression scenario. |
CHANGELOG.md |
Records the splitter stacking fix. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
CHANGELOG.mdentry under[Unreleased]