Repository navigation
fix(OmniH2O): 第 9 幕「更新学生」改成从损失连到学生的虚线箭头,只重渲这一幕 - #638
Merged
Merged
Conversation
- 原来这条虚线只画了半截(四个点只用了前两个)、没箭头,离学生框差 22 个单位,看不出是什么;改成画到学生框的虚线箭头,小圆点往上跑,标「梯度回传 / 更新学生」 - 旁边的绿色实线标上「学生自己的 a_t」,两条线各说各的 - 旁白没变,只重渲帧 11,340–12,546,其余按帧号拼接上一版的分段,接缝新旧帧平均差 0.12–0.22 灰度级;整片 24,136 帧、804.53 / 804.53 s,网页版仍是 15.1 MB - check_layout.mjs 可在末尾加时间段只查改过的几幕;测试守住这支箭头 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XgFzxdYKHJTJgs5FJfMyB
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XgFzxdYKHJTJgs5FJfMyB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
接 #636(OmniH2O 笔记、十七幕动画与视频),按看片反馈修第 9 幕「DAgger:学生开车,老师批改」。
问题
改动
tests/test_paper_demos.py守住这支箭头:要用arrow()画到学生框,不能再出现up.slice(0, 2)。视频
render.mjs chunk并行,每个约 40 s。-crf 37仍是 15.1 MB,已替换笔记media/里的视频,文案里的体积不用改。工具
check_layout.mjs可以在末尾加时间段,只查改过的几幕,例如node check_layout.mjs omnih2o story near 378,418。检查
check_layout.mjs omnih2o story near 378,418:no overlappytest:305 passed;ruff check scripts/ tests/:通过第 9 幕修复前(左)与修复后(右),取自成片第 398 s:
<img alt="第 9 幕更新学生箭头修复前后" src="
https://github.com/ImChong/Robot_Learning_Paper_Notebooks/blob/5a677d9eb330107d467332d24e845b3684565901/.github/pr-assets/pr-omnih2o-scene9-update-arrow.png?raw=true"/>🤖 Generated with Claude Code
https://claude.ai/code/session_019XgFzxdYKHJTJgs5FJfMyB
Generated by Claude Code