Skip to content

fix(preview): isolate the Pages deploy directory #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoland merged 1 commit into from
Aug 18, 2026
Merged

fix(preview): isolate the Pages deploy directory #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pages-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ jobs:
--public-origin "$PREVIEW_ORIGIN" \
--output .preview-registry
cp -R .preview-registry/. apps/client-web/dist/
cp -R apps/client-web/dist "$GITHUB_WORKSPACE/.pages-preview"

- name: Reverify pull-request identity before delivery
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
Expand Down Expand Up @@ -185,7 +186,7 @@ jobs:
accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
packageManager: npm
wranglerVersion: 4.114.0
workingDirectory: candidate/apps/client-web/dist
workingDirectory: .pages-preview
command: >-
pages deploy .
--project-name=${{ vars.CLOUDFLARE_PAGES_PROJECT }}
Expand Down
3 changes: 2 additions & 1 deletion scripts/native-extension-distribution.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,8 @@ test('separates exact-main app delivery from the Changesets Extension release li
assert.match(preview, /pnpm build/)
assert.match(preview, /pdm run inkcre-ext preview build/)
assert.match(preview, /--public-origin "\$PREVIEW_ORIGIN"/)
assert.match(preview, /workingDirectory: candidate\/apps\/client-web\/dist/)
assert.match(preview, /cp -R apps\/client-web\/dist "\$GITHUB_WORKSPACE\/\.pages-preview"/)
assert.match(preview, /workingDirectory: \.pages-preview/)
assert.match(preview, /pages deploy \./)
assert.doesNotMatch(preview, /INKCRE_EXTENSION_REGISTRY_TOKEN/)

Expand Down
Loading