Fix: Several small codebase fixes - #413
Open
AnnaSasDev wants to merge 14 commits into
Open
Conversation
This change removes lazy logger lookups and instead uses injected ILogger instances across the WebView manager and related window features. It also replaces Debug.WriteLine calls in disposal/finalizer paths with structured logging when a logger is available, and resolves logger instances from the window service provider in monitor and external URL handlers. Tests were updated to pass the new logger dependency for the WebView manager.
This change introduces an abstraction for external process startup and registers it in DI so web-message handlers can be unit tested without launching real browser processes. It also modernizes several array and collection initializations to use collection expressions and adds broader coverage around native interop status, static asset manifest handling, file picker/filter behavior, and web-message dispatch flows.
Change coverage workflow to run on ubuntu-latest and harden the coverage_report script. Adds explicit encoding="utf-8" to subprocess.run for consistent UTF-8 handling and checks that gh API output is non-empty before calling strip to avoid errors when stdout is None or empty. Files changed: .github/workflows/shared-coverage.yml, scripts/coverage_report.py.
Refactors external process launching into the InfiniFrame.Interop namespace and adds the concrete launcher implementation to the shared project. The service registration is updated to resolve the interface from the new namespace, and related tests are adjusted to match the new contracts and analyzer cleanups.
This change excludes native C/C++/Objective-C source files from Cobertura coverage parsing so they do not inflate coverage totals. It also adds tests covering the new exclusion behavior for native file filtering alongside the existing test package exclusions.
Contributor
📊 Code Coverage Report
C# Project Breakdown
|
Avoid inflated line coverage by deduplicating tracked line numbers per class before counting covered and total lines. This keeps method-level duplicates from inflating IL while preserving coverage from any positive-hit line. Added a regression test covering duplicate line numbers across methods in the same class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.