Repository navigation
fix: npm install fails on Windows with Node 24+ (better-sqlite3 native build) #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fa0dd5d
fix: npm install fails on Windows with Node 24+ (better-sqlite3 nativ…
4139494
fix: address review — CI catches a source compile; preflight local pu…
4239e5b
refactor: name the better-sqlite3 type import Database, matching the …
0f1c6a1
fix: detect a blocked native binary (npm 12 allowScripts) and say how…
40efcfe
chore(release): 0.0.1-beta.34 — Windows install on Node 24+ (better-s…
897e096
chore: review nits — --allow-scripts in the upgrade fallback hint and…
c1fde6b
docs: keep the plain install command; --allow-scripts only in the fai…
8d995b8
docs(readme): npm 12 note under Requirements
adf2270
fix(local clone): warn up front when SQLite is missing; never report …
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BUG: Wrong
process.argvindex — should beprocess.argv[2], notprocess.argv[1]When running
node -e "script" $cli, the Node process receives:process.argv[0]='node'process.argv[1]= the-escript stringprocess.argv[2]=$cli(the CLI path)The code uses
process.argv[1]which is the script itself, not the argument. This works by accident becauserequire.resolvefalls back to default resolution, but it's incorrect.Reply with
@kilocode-bot fix itto have Kilo Code address this issue.