Replace typing.List and other aliases w/ builtin equivalents after Python 3.10 - #496
Replace typing.List and other aliases w/ builtin equivalents after Python 3.10#496yangdanny97 wants to merge 4 commits into
typing.List and other aliases w/ builtin equivalents after Python 3.10#496Conversation
|
Oh, I just realized this is almost a duplicate of #482 This one adds |
🤖 Automated Code Review📊 Pull Request Review SummaryOverviewThis pull request proposes a change to replace type annotations from the 🎯 Key Findings
🔍 Detailed Issues🔴 Critical IssuesNone found. 🟠 High Priority IssuesNone found. 🟡 Medium Priority IssuesNone found. 🟢 Low Priority IssuesNone found. ✅ Positive Aspects
📝 Overall AssessmentThis pull request is well-executed and enhances the clarity and maintainability of the codebase while promoting adherence to the latest Python standards. There are no issues found, and this PR can be merged without reservations. Great job to the author on these changes! ✅ No issues found! Code looks good.Generated by PR Review Agent |
|
Hi @yangdanny97! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
This is the inverse of UseTypesFromTyping https://github.com/Instagram/Fixit/blob/main/src/fixit/rules/use_types_from_typing.py
In Python versions after 3.10, we can replace
typing.Listand other aliases with the builtin equivalents.Test Plan
makecloses #482