Upgrade Click and ufmt - #574
Open
HayaoSuzuki wants to merge 1 commit into
Open
Conversation
Require Click 8.3.3 or newer to address PYSEC-2026-2132, and update ufmt to 2.9.1. Adapt the CLI tests to Click's separate stdout and stderr streams. Preserve Fixit's no-argument help behavior after Click 8.2 changed the default exit status and stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>=8.0,<8.2to>=8.3.3,<9to addressPYSEC-2026-2132.mix_stderrparameter fromCliRunnerand changedResult.outputto mix stdout and stderr. UseCliRunner()and assert againstResult.stdoutin the CLI tests.fixitto exit 2 and write help to stderr. Preserve Fixit's existing behavior, in whichfixitprints help to stdout and exits 0 while option-only invocations still report a missing command.clickdependency has an attached CVE #570Test Plan
pyrefly check -c pyproject.tomlpython -m flake8 src/fixit/ scripts/python -m fixit lint src/fixit/ scripts/python scripts/check_copyright.pypython -m buildmake lintstops atpython -m ufmt check, which reports the same 27 paths on this branch andorigin/mainwith Black 26.3.1 from Bump black #560. Flake8, Fixit lint, and the copyright check pass.