Skip to content

Remove wildcard imports in dpnp.fft and dpnp.random submodules - #2649

Merged
vlad-perevezentsev merged 10 commits into
masterfrom
remove_wildcard_import
Nov 12, 2025
Merged

Remove wildcard imports in dpnp.fft and dpnp.random submodules#2649
vlad-perevezentsev merged 10 commits into
masterfrom
remove_wildcard_import

Conversation

@vlad-perevezentsev

@vlad-perevezentsev vlad-perevezentsev commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR proposes to remove wildcard imports from dpnp.fft and dpnp.random submodules and register them as explicit submodules in dpnp namespace.

It also removes wildcard import of dpnp.memory from dpnp_iface.py

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Nov 4, 2025
@vlad-perevezentsev vlad-perevezentsev changed the title Remove wildcard import Remove wildcard imports Nov 4, 2025
@github-actions

github-actions Bot commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls

coveralls commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 81.453% (-0.007%) from 81.46%
when pulling ead9085 on remove_wildcard_import
into 4082593 on master.

@github-actions

github-actions Bot commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_49 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Nov 8, 2025
@vlad-perevezentsev vlad-perevezentsev changed the title Remove wildcard imports Remove wildcard imports in dpnp.fft and dpnp.random submodules Nov 11, 2025
@vlad-perevezentsev
vlad-perevezentsev marked this pull request as ready for review November 11, 2025 14:14
antonwolfy
antonwolfy reviewed Nov 11, 2025
View reviewed changes
Comment thread dpnp/fft/__init__.py Outdated
antonwolfy
antonwolfy approved these changes Nov 11, 2025
View reviewed changes

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vlad-perevezentsev

@vlad-perevezentsev
vlad-perevezentsev merged commit 7eed7da into master Nov 12, 2025
83 of 91 checks passed
@vlad-perevezentsev
vlad-perevezentsev deleted the remove_wildcard_import branch November 12, 2025 12:47
github-actions Bot added a commit that referenced this pull request Nov 12, 2025
@github-actions
Remove wildcard imports in dpnp.fft and dpnp.random submodules (#…
95dbd65 
…2649)

This PR proposes to remove wildcard imports from `dpnp.fft` and
`dpnp.random` submodules and register them as explicit submodules in
`dpnp` namespace.
It also removes wildcard import of `dpnp.memory` from `dpnp_iface.py` 7eed7da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes
@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@vlad-perevezentsev @coveralls @antonwolfy