Skip einsum test_out_0d for NumPy older than 2.4.5 - #3030
Merged
Conversation
The reference numpy.einsum call with a 0-d out array and optimize="optimal" only behaves as expected starting with NumPy 2.4.5, so guard test_out_0d with the corresponding version requirement.
7 tasks
antonwolfy
marked this pull request as ready for review
August 17, 2026 10:11
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
August 17, 2026 10:11
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev4=py314h509198e_7 ran successfully. |
Collaborator
|
coverage: 78.467%. remained the same — skip-einsum-out-0d-old-numpy into master |
ndgrigorian
approved these changes
Aug 17, 2026
github-actions Bot
added a commit
that referenced
this pull request
Aug 17, 2026
This guards `TestEinsum.test_out_0d` with
`@testing.with_requires("numpy>=2.4.5")`.
The test compares `dpnp.einsum` against a reference `numpy.einsum` call
that uses a 0-d `out` array with `optimize="optimal"`. That reference
behavior only matches on NumPy 2.4.5 and newer, so the test is skipped
on older NumPy versions to avoid spurious failures.
The test was introduced in #2987. 2191b84
ndgrigorian
pushed a commit
that referenced
this pull request
Aug 17, 2026
This guards `TestEinsum.test_out_0d` with
`@testing.with_requires("numpy>=2.4.5")`.
The test compares `dpnp.einsum` against a reference `numpy.einsum` call
that uses a 0-d `out` array with `optimize="optimal"`. That reference
behavior only matches on NumPy 2.4.5 and newer, so the test is skipped
on older NumPy versions to avoid spurious failures.
The test was introduced in #2987.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This guards
TestEinsum.test_out_0dwith@testing.with_requires("numpy>=2.4.5").The test compares
dpnp.einsumagainst a referencenumpy.einsumcall that uses a 0-doutarray withoptimize="optimal". That reference behavior only matches on NumPy 2.4.5 and newer, so the test is skipped on older NumPy versions to avoid spurious failures.The test was introduced in #2987.